BUG: interpolate/ndbspline: fix OOB access for len(tx) != len(ty) in tensor product splines #19581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…product splines To be able to release the GIL, we pack the tuple of 1D knot arrays into a 2D array. Since the lengths of knot arrays for different dimensions may differ, the 2D array has dimensions (ndim, max_length), with extra elements filled with NaNs. The actual lengths of knot arrays need to be known to the interval search routine, which finds for a given `x`, the index `i` such that `t[i] <= x < x[i+1]`. Otherwise these extra nans confuse the interval search routine, leading to OOB access down the line.
ev-br
added
defect
|
Have tentatively added the 1.12 milestone, on the grounds of fixing a bug in a routine which itself is new in 1.12. OTOH not a big deal if it does not make it to 1.12.0. |
tylerjereddy
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
I did a quick check that the regression test fails for me on latest main, and beyond that I'm happy to merge given that:
- no old tests were changed, just a new regression test added
- CI is passing, the 1 failure is unrelated
- if this does cause issues, I'm sure Evgeni will help me patch it for a subsequent release
- we're aiming to branch soon-ish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to release the GIL, we pack the tuple of 1D knot arrays into a 2D array. Since the lengths of knot arrays for different dimensions may differ, the 2D array has dimensions (ndim, max_length), with extra elements filled with NaNs.
The actual lengths of knot arrays need to be known to the interval search routine, which finds for a given
x, the indexisuch thatt[i] <= x < x[i+1]. Otherwise these extra nans confuse the interval search routine, leading to OOB access down the line.