MAINT: stats.theilslopes: consistent promotion of x and y
#19679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
maintenance
lucascolley
approved these changes
Dec 11, 2023
[skip ci] Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
|
Oops, thanks. Wow, that rule is turned off in the lint check, too? (I wouldn't propose turning it on. Pretty rare for me to miss that one.) |
j-bowhay
approved these changes
Dec 12, 2023
nprav
pushed a commit
to nprav/scipy
that referenced
this pull request
Dec 13, 2023
…19679) * MAINT: stats.theilslopes: consistent promotion of x and y * Update scipy/stats/tests/test_mstats_basic.py [skip ci] Co-authored-by: Lucas Colley <lucas.colley8@gmail.com> --------- Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-19678
What does this implement/fix?
stats.theilslopesdid not respect the dtype of user inputx, always promoting it tofloatbefore performing calculations. Even whenxwas not provided, it createdxwithfloatdtype. However, it respected the dtype of user-providedyto a fault, even allowing it to remain an unsigned integer type. This led to the unexpected results in gh-19678.It is a known issue that
statsdoes not have a consistent policy for respecting input dtype when performing calculations (gh-14651). That is a much larger issue, so I don't address it here. This PR takes the simple route: promoteyjust likex.Additional information
Please select "Hide whitespace" when reviewing the diff; I just gathered all the
theilslopestests into a class.