-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
MAINT:linalg: Remove redundant det and lu Fortran files #19687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Opinions on also getting rid of
|
Oh I completely forgot those. Let me check what they do. |
a836dab
to
b9c5116
Compare
I agree, removed them now. |
edit: happy to make a PR to your branch if you'd prefer |
Oh my if it is not a hassle please go ahead, I don't know how I missed them. Thanks for the drill down though. |
MAINT: linalg: clean-up for `flinalg` removal
CI happy (not sure what's up with Cirrus), just need to decide whether Lines 947 to 955 in e00a594
|
That comment has no relevance anymore hence I removed it. It was when we tried to use F or C linalg based on the array flag but that's long gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both! Nice to see ~600 lines go
Thanks @lucascolley for the emergency save, @j-bowhay |
#18358 finalized replicating the work that these old Fortran files were used for. This PR removes the files themselves.