ENH: add BSpline.insert_knot method
#19777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
The `x` parameter was documented as array_like, but in fact only scalars are accepted.
to mirror FITPACK's `insert` routine.
h-vetinari
reviewed
Jan 18, 2024
There was a problem hiding this comment.
I tried to have a look here, and AFAICT, things look pretty good. I don't know the classes involved here very well though, and I don't undersand everything, especially not what's happening with self.k and slicing backwards.
The variable naming in the new tests is also not ideal (spl, spl_1f, spl_1), but the tests do indicate that the implementation essentially matches our existing wrappers, so that's a great status already.
h-vetinari
approved these changes
Jan 20, 2024
|
Core dev approved, has no backwards compat issues. Merging in. Thanks for tge reviews @j-bowhay , @h-vetinari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add a
BSpline.insert_knotmethod to parallel the module-levelinsertroutine. The latter is a wrapper around FITPACK, and the new routine has a small cython snippet instead.This can be further optimized, especially for multiple knots: ATM
m > 1incursmallocations, each being linear in data. However for the first version let's keep it simple, and optimize on a user request.To get feature-completeness, still need to port FITPACK's handling of periodic boundary conditions.this is done now.Additional information
This PR only adds functionality, and does not remove anything Fortran, not just yet.