Skip to content

Conversation

thalassemia
Copy link
Contributor

This resolves a compiler-specific warning that I encountered at some point during my testing with either MSVC or the Intel compilers (don't remember which).

@thalassemia thalassemia requested a review from steppi as a code owner January 7, 2024 11:03
@github-actions github-actions bot added scipy.integrate Build issues Issues with building from source, including different choices of architecture, compilers and OS labels Jan 7, 2024
@lucascolley lucascolley added Fortran Items related to the internal Fortran code base and removed scipy.integrate labels Jan 7, 2024
@lucascolley lucascolley added this to the 1.13.0 milestone Jan 7, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thalassemia!

With Clang on macOS these warnings were visible too, and are indeed resolved now:

[9/12] Compiling C object scipy/integrate/_lsoda.cpython-310-darwin.so.p/meson-generated_..__lsodamodule.c.o
scipy/integrate/_lsodamodule.c:1045:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
                (*f2py_func)(cb_f_in_lsoda__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,rwork,&lrw,iwork,&liw,cb_jac_in_lsoda__user__routines,&jt) ;
                            ^
1 warning generated.
[11/12] Compiling C object scipy/integrate/_vode.cpython-310-darwin.so.p/meson-generated_..__vodemodule.c.o
scipy/integrate/_vodemodule.c:1452:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
                (*f2py_func)(cb_f_in_dvode__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,rwork,&lrw,iwork,&liw,cb_jac_in_dvode__user__routines,&mf,&rpar,&ipar) ;
                            ^
scipy/integrate/_vodemodule.c:1810:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
                (*f2py_func)(cb_f_in_zvode__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,zwork,&lzw,rwork,&lrw,iwork,&liw,cb_jac_in_zvode__user__routines,&mf,&rpar,&ipar) ;
                            ^
2 warnings generated.

@rgommers rgommers changed the title BLD: resolve missing prototype warnings BLD: resolve missing prototype warnings in lsoda/vode Jan 7, 2024
@rgommers rgommers merged commit 1276335 into scipy:main Jan 7, 2024
@lucascolley lucascolley removed the request for review from steppi January 7, 2024 16:41
@thalassemia thalassemia deleted the missing_proto branch March 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS Fortran Items related to the internal Fortran code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants