BLD: fix issue with escape sequences in __config__.py
#19945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in conda-forge/scipy-feedstock#264: linker args contained a `\s` on Windows as part of a path in a linker flag. This is basically the same bug as scipygh-17936, it was fixed for paths in `__config__.py` but not for things like linker flags which usually don't contain a path but may do so. Now turn everything except name/version/found/id, which really should not contain escapes, into raw strings. [skip circle] [skip cirrus]
rgommers
added
maintenance
github-actions
bot
added
the
Build issues
1 task
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Jan 23, 2024
The current code isn't robust to backslashes (from path segments on Windows) in linker flags. No bug report for NumPy, but the same problem did show up in SciPy already. Fix is the same as scipy/scipy#19945 [skip cirrus] [skip circle]
charris
added a commit
to charris/numpy
that referenced
this pull request
Jan 23, 2024
Backport of numpy#25669. The current code isn't robust to backslashes (from path segments on Windows) in linker flags. No bug report for NumPy, but the same problem did show up in SciPy already. Fix is the same as scipy/scipy#19945. This actually pulls in all of `__config__.py` from main because there have been a number of other changes. [skip cirrus] [skip circle]
charris
added a commit
to charris/numpy
that referenced
this pull request
Jan 23, 2024
Backport of numpy#25669. The current code isn't robust to backslashes (from path segments on Windows) in linker flags. No bug report for NumPy, but the same problem did show up in SciPy already. Fix is the same as scipy/scipy#19945. This actually pulls in all of `__config__.py` from main because there have been a number of other changes. [skip cirrus] [skip circle]
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in conda-forge/scipy-feedstock#264: linker args contained a
\son Windows as part of a path in a linker flag.This is basically the same bug as gh-17936, it was fixed for paths in
__config__.pybut not for things like linker flags which usually don't contain a path but may do so.Now turn everything except name/version/found/id, which really should not contain escapes, into raw strings.