BUG: interpolate: make BSpline.integrate always return an array #20833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the return value was either an array (possibly 0D) or a python float. Given that __call__ always returns 0D arrays, and so is PPoly.__call__ and PPoly.integrate, there is really no fundamental reason to not make the return type stable. Strictly speaking, this is a backwards compat break.
ev-br
added
defect
tupui
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the return value was either an array (possibly 0D) or a python float. Given that
BSpline.__call__always returns 0D arrays not python scalars, and so doPPoly.__call__andPPoly.integrate, there is really no fundamental reason for the dtype variation. (The actual reason is an oversight when adding a fast path).Strictly speaking, this is a backwards compat break. Still I'd say it's a bug, and the break should not be too bad for users.