Skip to content

Conversation

h-vetinari
Copy link
Member

Addressing a failure with MKL (c.f. #20472) which looks as follows:

FAILED cluster/tests/test_vq.py::TestKMean::test_krandinit[numpy] - AssertionError: 
Not equal to tolerance rtol=1e-07, atol=0.01

Mismatched elements: 1 / 400 (0.25%)
Max absolute difference among violations: 0.01098377
Max relative difference among violations: 0.00329683

IOW, there's a single element that breaks the atol tolerance by less than 10%.

@github-actions github-actions bot added the maintenance Items related to regular maintenance tasks label Jun 13, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously correct, in it goes. Thanks @h-vetinari

@rgommers rgommers merged commit ea8097f into scipy:main Jun 13, 2024
@rgommers rgommers added this to the 1.15.0 milestone Jun 13, 2024
@rgommers rgommers added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 13, 2024
@h-vetinari h-vetinari deleted the mkl_tol branch June 13, 2024 08:54
@tylerjereddy tylerjereddy modified the milestones: 1.15.0, 1.14.0 Jun 14, 2024
@tylerjereddy tylerjereddy mentioned this pull request Jun 14, 2024
4 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants