Skip to content

Conversation

tylerjereddy
Copy link
Contributor

  • Remove the guard inside test_plot_iv() now that matplotlib provides a NumPy 2 compatible version.

  • Similarly, reactivate matplotlib prerelease CI testing for one case where it was disabled for a similar reason.

[skip circle] [skip cirrus]

* Remove the guard inside `test_plot_iv()` now that `matplotlib`
provides a NumPy 2 compatible version.

* Similarly, reactivate `matplotlib` prerelease CI testing
for one case where it was disabled for a similar reason.

[skip circle] [skip cirrus]
@tylerjereddy tylerjereddy added scipy.stats maintenance Items related to regular maintenance tasks CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Jun 18, 2024
@tylerjereddy tylerjereddy added this to the 1.15.0 milestone Jun 18, 2024
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Tyler!

@lucascolley lucascolley changed the title CI, MAINT: test_plot_iv NumPy 2 shim CI, MAINT: test_plot_iv NumPy 2 shim Jun 18, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, and the one CI failure is unrelated. In it goes, thanks @tylerjereddy

@rgommers rgommers merged commit e707663 into scipy:main Jun 18, 2024
@tylerjereddy tylerjereddy deleted the treddy_test_plot_iv_numpy2 branch June 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure maintenance Items related to regular maintenance tasks scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants