Skip to content

Conversation

lobpcg
Copy link
Contributor

@lobpcg lobpcg commented Jul 7, 2024

Reference issue

Closes gh-19446

What does this implement/fix?

Make the test pass for all possible dtypes

@lobpcg lobpcg requested a review from perimosocordiae as a code owner July 7, 2024 20:09
@lucascolley lucascolley changed the title In test_b_orthonormalize, add tests for all DTYPES TST: sparse.linalg: test all dtypes for lobpcg B-orthonormalization Jul 7, 2024
@lucascolley lucascolley added the maintenance Items related to regular maintenance tasks label Jul 7, 2024
@lobpcg
Copy link
Contributor Author

lobpcg commented Jul 13, 2024

The PR is finished and needs reviews and or merge please.

[skip ci]
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lobpcg

@j-bowhay j-bowhay added this to the 1.15.0 milestone Jul 14, 2024
@j-bowhay j-bowhay merged commit 190f39e into scipy:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.sparse.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: In test_b_orthonormalize, cannot parameterize Vdtype, Bdtype, or BVdtype using VDTYPES
3 participants