Skip to content

MAINT: special: Make fixes needed for ellipkinc and ellipeinc to work on CUDA #21163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2024
Merged

MAINT: special: Make fixes needed for ellipkinc and ellipeinc to work on CUDA #21163

merged 3 commits into from
Jul 16, 2024

Conversation

steppi
Copy link
Contributor

@steppi steppi commented Jul 11, 2024

This PR adds tests for ellipkinc and ellipeinc to special/tests/test_xsf_cuda.py and makes some fixes that are needed for these functions to work on CUDA through CuPy. I plan to also make a PR to CuPy to add these two functions.

cc @rlucas7

@steppi steppi requested a review from person142 as a code owner July 11, 2024 20:19
@github-actions github-actions bot added scipy.special C/C++ Items related to the internal C/C++ code base Meson Items related to the introduction of Meson as the new build system for SciPy maintenance Items related to regular maintenance tasks labels Jul 11, 2024
@rgommers rgommers added this to the 1.15.0 milestone Jul 16, 2024
rgommers
rgommers approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a pretty straightforward fix, so let's get it in. Thanks @steppi

@rgommers rgommers merged commit 8724cee into scipy:main Jul 16, 2024
@rlucas7
Copy link
Member

rlucas7 commented Jul 16, 2024

This looks like a pretty straightforward fix, so let's get it in. Thanks @steppi

Thanks @rgommers

@steppi
Copy link
Contributor Author

steppi commented Jul 16, 2024

Thanks @rgommers! I appreciate it

@rgommers rgommers mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@person142 person142 Awaiting requested review from person142 person142 is a code owner

Assignees
No one assigned
Labels
C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy scipy.special
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@steppi @rlucas7 @rgommers