MAINT: test_maxiter_worsening cleanup
#21281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes scipygh-13019 * Remove an inactive `xfail` from `test_maxiter_worsening`, since we no longer support Python `3.9.x` on `main`. Caution: I do see a user report of a Python `3.10` problem in the linked issue as well, so perhaps we might want to check the wheel builds before merging if Cirrus/whatever we have for ARM Linux testing doesn't have us covered. * While cleaning up old version checks, remove another stale check from `dev.py`, which cannot be satisfied with our current supported version bounds. [skip circle]
lucascolley
changed the title
test_maxiter_worsening cleanup
rgommers
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks @tylerjereddy! This should be safe to merge without running wheel builds; nothing is changing there since tests currently pass on Python 3.10-3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TST, MAINT: test_maxiter_worsening on Python 3.9 + Linux ARM64 #13019
Remove an inactive
xfailfromtest_maxiter_worsening, since we no longer support Python3.9.xonmain. Caution: I do see a user report of a Python3.10problem in the linked issue as well, so perhaps we might want to check the wheel builds before merging if Cirrus/whatever we have for ARM Linux testing doesn't have us covered. That said, the issue is almost 4 years old, and referred to the old macpython wheel builds, so many things have changed since then.While cleaning up old version checks, remove another stale check from
dev.py, which cannot be satisfied with our current supported version bounds.[skip circle]