-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
BLD: cp313 wheels on manylinux_aarch64
#21409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rgommers, do you know why the build script for
|
Looking at the log, something else might be failing first? |
ci/cirrus_wheels.yml
Outdated
# cirrus-ci task). | ||
- env: | ||
CIBW_BUILD: cp310-manylinux* | ||
CIBW_BUILD: cp310-manylinux* cp313-manylinux* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that below, where we have pip install numpy>=2.0.0.dev0
, we'll need an adjustment for Python 3.13.0rc1
. Well, Chuck may be about to release a stable version of 3.13
-compatible NumPy 2.1.0
soon, but at the moment I can make more progress on a Linux aarch64
Python 3.13.0rc1
setup when I change that to pip install numpy==2.1.0rc1
(though we likely only want that, or a similar way to get at least that pre-release, for 3.13.0rc1
).
gh-19565 had the same error message (well, the same final line, no idea if it's a related issue or not) EDIT: it looks like we do have meson-python here, so shouldn't be the same thing? |
Messing around locally it seems that removing the environment variables for PIP_NO_BUILD_ISOLATION, PIP_PRE, PIP_EXTRA_INDEX_URL seems to fix things. Let's see how this build goes. |
Ok this works. The failing tests are orthogonal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @andyfaff !
manylinux_aarch64
Since this is relatively small PR, would a backcourt to 1.14.1 still be possible? That would bring some architecture parity in the Python 3.13 wheels offered with the next release. |
It has been backported! 0f91838 |
must be a vigilant release manager |
Was already done, sorry for the noise. @tylerjereddy thanks for all your work! |
@tylerjereddy