MAINT: special.logsumexp: enforce branch cut convention #21622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.special
maintenance
github-actions
bot
added
maintenance
mdhaber
commented
Sep 24, 2024
| # outside the range (-pi, pi]. Check that this is resolved. | ||
| # While working on this, I noticed that all other tests passed even | ||
| # when the imaginary component of the result was zero. This suggested | ||
| # the need of a stronger test with imaginary dtype. |
There was a problem hiding this comment.
Would be good to include a test with b, or maybe just a separate property-based test of the basic behavior for all input types and options. If this looks good as-is, though, let's make that a separate PR since it's not urgent.
mdhaber
commented
Sep 30, 2024
|
|
||
| def _wrap_radians(x): | ||
| # Wrap radians to -pi, pi interval | ||
| return (x + math.pi) % (2 * math.pi) - math.pi |
There was a problem hiding this comment.
@steppi it occurs to me that this would lose precision near lazywhere. Do we want to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-21610
What does this implement/fix?
gh-21610 noted that
logsumexpcould return imaginary components outside the range (-pi, pi] after the changes in gh-21597. This PR enforces the original branch cut convention and documents it.