TST: skip|xfail_xp_backends disregards reason=

[crusaderky]

Fix bug where

skip_xp_backends(cpu_only=True, reason=...)
skip_xp_backends(np_only=True, reason=...)
xfail_xp_backends(cpu_only=True, reason=...)
xfail_xp_backends(np_only=True, reason=...)

would disregard the user-provided reason and instead always used the default.

Also, when a test is decorated by

@skip_xp_backends(cpu_only=True)
@skip_xp_backends("torch")

the reason for the specific backend will now trump the one given for cpu_only (see evidence in comment below).

[crusaderky]

Redundant with pytest's own error

[ev-br]

LGTM

[lucascolley]

what happens if we perform a cpu_only skip and a skip with torch in backends - which reason takes precedence when using torch CUDA? If so, is that what we want?

[crusaderky]

what happens if we perform a cpu_only skip and a skip with torch in backends - which reason takes precedence when using torch CUDA? If so, is that what we want?

The reason from cpu_only took precedence, and it's most likely not what we want. I've updated the PR:

@skip_xp_backends(cpu_only=True, reason="cpu reason")
@skip_xp_backends("torch", reason="torch reason")
def test1(xp):
    pass

$ python dev.py test -v
scipy/signal/tests/test_signaltools.py::test1[numpy] PASSED                                                                                          [ 20%]
scipy/signal/tests/test_signaltools.py::test1[array_api_strict] PASSED                                                                               [ 40%]
scipy/signal/tests/test_signaltools.py::test1[torch] SKIPPED (torch reason)                                                                          [ 60%]
scipy/signal/tests/test_signaltools.py::test1[cupy] SKIPPED (cpu reason)                                                                             [ 80%]
scipy/signal/tests/test_signaltools.py::test1[jax.numpy] PASSED           

$ SCIPY_DEVICE=cuda python dev.py test -v
scipy/signal/tests/test_signaltools.py::test1[numpy] PASSED                                                                                          [ 20%]
scipy/signal/tests/test_signaltools.py::test1[array_api_strict] PASSED                                                                               [ 40%]
scipy/signal/tests/test_signaltools.py::test1[torch] SKIPPED (torch reason)                                                                          [ 60%]
scipy/signal/tests/test_signaltools.py::test1[cupy] SKIPPED (cpu reason)                                                                             [ 80%]
scipy/signal/tests/test_signaltools.py::test1[jax.numpy] SKIPPED (cpu reason) 

[lucascolley]

can you update the docstring now that a custom reason is allowed with cpu_only

[crusaderky]

can you update the docstring now that a custom reason is allowed with cpu_only

done

[lucascolley]

thanks @crusaderky !