Skip to content

Conversation

HaoZeke
Copy link
Contributor

@HaoZeke HaoZeke commented Jan 18, 2025

Fix suggested by @drew-parsons , and seems to work alright, highs symbols are present in _core.so anyway.

Closes #22349

Co-authored-by: drew-parsons <drew-parsons@users.noreply.github.com>

Closes scipy#22349
@HaoZeke HaoZeke requested a review from andyfaff as a code owner January 18, 2025 17:31
@github-actions github-actions bot added scipy.optimize Meson Items related to the introduction of Meson as the new build system for SciPy maintenance Items related to regular maintenance tasks labels Jan 18, 2025
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, thanks @HaoZeke!

@lucascolley lucascolley added this to the 1.15.2 milestone Jan 19, 2025
@lucascolley lucascolley added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jan 19, 2025
@lucascolley lucascolley merged commit f4e74dd into scipy:main Jan 19, 2025
39 of 40 checks passed
@HaoZeke HaoZeke deleted the noHighsLib branch January 19, 2025 02:58
@tylerjereddy tylerjereddy mentioned this pull request Feb 5, 2025
7 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: libhighs.a static library is installed
3 participants