ENH: special: softmax / log_softmax Array API support
#22633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.special
Meson
crusaderky
commented
Mar 5, 2025
Comment on lines
403
to
+406
| # suppress warnings about log of zero | ||
| with np.errstate(divide='ignore'): | ||
| s = np.sum(exp_tmp, axis=axis, keepdims=True) | ||
| out = np.log(s) | ||
| s = xp.sum(exp_tmp, axis=axis, keepdims=True) | ||
| out = xp.log(s) |
There was a problem hiding this comment.
In order to suppress warnings on dask, we would need to replace this with xpx.apply_where
lucascolley
added
array types
j-bowhay
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scipy.special.softmaxandscipy.special.log_softmax, including no-compute Dask andjax.jitlog_softmaxto bring them in line with all other testslogsumexpand_wrap_radiansunder no-compute Dask andjax.jit