Skip to content

Conversation

rgommers
Copy link
Member

This reduces the size of the sdist by about 50%, from 60 MB to 30 MB.

Also remove some images from doc/source/_static/gitpod. The doc content that used them was removed a long time ago.

@rgommers rgommers added the Meson Items related to the introduction of Meson as the new build system for SciPy label Apr 30, 2025
@rgommers rgommers added this to the 1.16.0 milestone Apr 30, 2025
@rgommers rgommers requested review from tupui and larsoner as code owners April 30, 2025 19:24
@github-actions github-actions bot added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org Build issues Issues with building from source, including different choices of architecture, compilers and OS labels Apr 30, 2025
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command I usually use for sdist generation for releases indeed has a resulting tarball that drops in size from 57 MB->29 MB locally.

The changes look sensible to me as well, and the CI seems to have at least two sdist-related jobs that passed.

meson docs suggest this command runs after the sources are moved in, but before the archive is populated. I guess that makes sense.

@tylerjereddy tylerjereddy merged commit 5f974b1 into scipy:main May 1, 2025
41 checks passed
@tylerjereddy
Copy link
Contributor

thanks Ralf, Lucas

@rgommers rgommers deleted the fix-sdist-excludes branch May 1, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org Meson Items related to the introduction of Meson as the new build system for SciPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants