ENH: signal.cspline1d_eval,qspline1d_eval throw exception for empty cj array
#22992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
approved these changes
May 16, 2025
There was a problem hiding this comment.
Confirmed it fails with the recursion error on scipy 1.5.2, too, so the problem is not a recent regression. Thus no backwards compat considerations, and a descriptive error is nice.
Let's land this.
Thanks @zitongzhoueric , keep them coming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty cj array should be invalid argument to spline evaluation. Without the guard the mirror symmetry implementation would lead to infinite recursion.