ENH: spatial: faster 2D Voronoi and Convex Hull plotting #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
changed the title
| _adjust_bounds(ax, hull.points) | ||
|
|
||
| return ax.figure | ||
|
|
||
|
|
||
| @_held_figure | ||
| def voronoi_plot_2d(vor, ax=None): | ||
| def voronoi_plot_2d(vor, ax=None, **kw): |
There was a problem hiding this comment.
Why not just add show_vertices=True here?
There was a problem hiding this comment.
I tried it as you suggest initially, but the _held_figure decorator was raising the following error:
TypeError: _held_figure() takes from 2 to 3 positional arguments but 4 were given
pv
added a commit
that referenced
this pull request
Oct 10, 2015
ENH: spatial: faster 2D Voronoi and Convex Hull plotting
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies
voronoi_plot_2dandconvex_hull_plot_2dto usematplotlib.collections.LineCollectionobjects. This removes the need for repeatedly callingax.ploton each individual line segment and speeds up plotting. This improvement is especially dramatic for the Voronoi case (approximately 13 times faster for me in the example below!).On my PC, for a set of 2000 randomly generated 2D points I got the following speedups
voronoi_plot_2d : previously 8.45 s -> now 0.63 s
convex_hull_plot_2d:| previously 111 ms -> now 83 ms
I also added an optional kwarg to
voronoi_plot_2dthat can be used to avoid adding the vertices to the plot. To my eye this looks cleaner, especially when there are a large number of points, but I have left the old behavior as the default.