Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Listing Objects with Prefixes Containing Special Characters #182

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Fix: Listing Objects with Prefixes Containing Special Characters #182

merged 4 commits into from
Aug 17, 2021

Conversation

jakobvogel
Copy link
Member

  • Restores computation of escaped key file names (broken in Fixes Concerning Keys with Special Characters #171, version 7.0.2)
  • Properly decodes file names before comparing them with the given prefix
  • Upgrades dependencies, fixing the broken transitive dependency

Closes #180.

@jakobvogel
Upgrades sirius 🪐
af4e02f 
This upgrade addresses the issue of a transitive dependency not being found.

#180
@jakobvogel
Adds a test case for the error reported by @Chocobozzz 🧪
db26e67 
Prefixes including special characters are not properly considered when listing objects due to file name escaping.

#180
@jakobvogel
Decodes the file name before use 🕵️‍♂️
0faffca 
#180
@jakobvogel
Fixes computation of effective URIs for the different use cases 🚑
3bf0e9d 
#180
@jakobvogel jakobvogel mentioned this pull request Aug 16, 2021
Closed
@jakobvogel jakobvogel merged commit 1ea50a5 into develop Aug 17, 2021
@jakobvogel jakobvogel deleted the feature/jvo/180-Listing-with-Prefix branch August 17, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyHa andyHa andyHa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty result using ListObjectsV2Command with Prefix containing special characters (/)
2 participants
@jakobvogel @andyHa