Added integration test for BIDS downloads #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @constellates. We're separately setting up automated integration test infra in #146. @rentzso: Please make sure this PR is set up to work with our new infra. |
There was a problem hiding this comment.
please change this line to
test_data.group_id = 'test_group_' + str(int(time.time()*1000))
we then avoid to use the same group for two different test.
|
@constellates the test is compliant with our infra. |
|
@rentzso Thanks for taking a look. I've added the group ID update. |
|
this has landed on https://github.com/poldracklab/bids-core Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gsfr @rentzso Here's the integration test to cover the BIDS upload and download functionality. It tests that the file structure is preserved for both full file downloads and symlinked downloads.
Let me know if you have any questions, concerns or requests.
Thanks