create proxy route to elasticsearch #170
Conversation
api/handlers/searchhandler.py
Outdated
| body = self.request.json_body if self.request.body else { | ||
| 'query': { | ||
| 'match_all': {} | ||
| } |
There was a problem hiding this comment.
Am I correct in thinking this... defaults to returning all documents if no query was passed?
There was a problem hiding this comment.
That does not seem like a good idea.
|
Looks like it accomplishes what's desired from the title. From earlier discussion I expected this to be a straight reverse-proxy, but this approach (using an ES client) makes sense. Did not test against our infra. @ryansanford Looks like there's a new key in |
requirements.txt
Outdated
| rfc3987==1.3.4 | ||
| webapp2==2.5.2 | ||
| WebOb==1.5.1 | ||
| elasticsearch>=1.0.0,<2.0.0 |
There was a problem hiding this comment.
Please pin this to an exact version like all other requirements.
There was a problem hiding this comment.
I was following this guidelines: http://elasticsearch-py.readthedocs.org/en/master/
|
👍 |
create proxy route to elasticsearch
3 participants
closes #168