Stop using handler.abort in validators #171
Conversation
raise exceptions instead (catched by base.RequestHandler.handle_exception)
|
Let's discuss the exception type before we merge. |
api/validators.py
Outdated
| _validate_json(payload, _schema, resolver_input) | ||
| except jsonschema.ValidationError as e: | ||
| handler.abort(400, str(e)) | ||
| raise webapp2.exc.HTTPBadRequest(str(e)) |
There was a problem hiding this comment.
Not having this be webapp2-aware would actually be nicer, wouldn't it?
There was a problem hiding this comment.
yeah probably the best thing to do is to catch the ValidationError in the handler calling the method
There was a problem hiding this comment.
I'd prefer a little more encapsulation. Your code shouldn't expose its internals, such as its use of jsonschema. You should rather define a ValidationException so that I can then say except validators.ValidationException.
There was a problem hiding this comment.
Just pushed a new commit. Added two exceptions to distinguish when the exception is critical(mongo schema validations).
rentzso
force-pushed
the
reduce-http-awareness
branch
from
d0186bb to
ea97a70
Compare
|
👍 |
|
LGTM, merge as desired |
Stop using handler.abort in validators
3 participants
raise exceptions instead (caught by
base.RequestHandler.handle_exception)partially addresses #66