Remove data bootstrapping; add folder reaping #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2016
|
@gsfr, |
Not happy with baking the pip requirement into the container. Need to think more. Also, instructions in docker/README.md are broken.
- Entrypoint has new $PRE_RUNAS_CMD that allows running of root tasks before dropping privs. - Added $SCITRAN_RUNTIME_PROTOCOL for explicit designation of http vs https. - Updated README.md examples. - No longer using requirements_dev.txt due to long install time.
gsfr
pushed a commit
that referenced
this pull request
Mar 9, 2016
Remove data bootstrapping; add folder reaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retires data bootstrapping in favor of folder reaping.
@ryansanford: Please and update the fly/fly dev infra accordingly. Note that
bootstrap.pyno longer parses environment variables in favor of command line arguments. Seerun.shfor invocation reference.There is still a branch reference in
requirements_dev.txtthat needs to be removed before merging. Requires scitran/reaper#17.Also, due to changes to
bootstrap.py, this conflicts with #146.