Skip to content

Conversation

hkethi002
Copy link
Contributor

Tests for the download filters

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem August 1, 2017 17:46
@hkethi002 hkethi002 force-pushed the download-filter branch 2 times, most recently from a3a7f0b to 8aff3bf Compare August 2, 2017 19:23
@nagem
Copy link
Contributor

nagem commented Aug 3, 2017

Thanks! It's interesting they were written to support filtering by tags on files, as that's not a very well supported use case (tagging files, usually it's containers). It will need to get supplemented/modified to support the requested use case of filtering by a broader list of fields but it's nice to know what is there works.

@ryansanford
Copy link
Contributor

@hkethi002
General question, not a blocker for this PR: I was expecting a bit for the coverage to go up, but it remained the same. Guessing that's because the same file type/tag filtering logic gets covered by other tests?

@hkethi002
Copy link
Contributor Author

hkethi002 commented Aug 3, 2017

Yeah, I think the filter is used already for tags but not types in the tests however, asserts are never made as to whether the filter actually filters the files

@hkethi002 hkethi002 merged commit 3e273f6 into master Aug 4, 2017
@hkethi002 hkethi002 deleted the download-filter branch August 4, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants