Node search #892
Merged
Node search #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagem
reviewed
Aug 11, 2017
api/handlers/dataexplorerhandler.py
Outdated
| size = self.search_size(return_type) | ||
| body = { | ||
| "size": 0, | ||
| "_source": ["session._id"], |
There was a problem hiding this comment.
we'll want this to be based on return_type, I'm sure this is just a hard code you missed taking out.
nagem
reviewed
Aug 11, 2017
api/handlers/dataexplorerhandler.py
Outdated
| return self.get_file_nodes(return_type, filters, search_string) | ||
|
|
||
| size = self.search_size(return_type) | ||
| body = { |
There was a problem hiding this comment.
I think we could just call "_construct_query" and change the "_source" key?
nagem
reviewed
Aug 11, 2017
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
and this would call "_construct_file_query" ?
nagem
reviewed
Aug 11, 2017
| nodes = [] | ||
| results = helpers.scan(client=config.es, query={'query': query}, scroll='5m', size=1000, index='data_explorer', doc_type='flywheel', _source=[return_type+'._id']) | ||
| log.debug(results) | ||
| for result in results: |
There was a problem hiding this comment.
and we'd want to set the source whitelist
|
Changes look good! I was originally confused about removing part of the |
nagem
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887
Returns list of nodes of all containers that are returned from a given search query
/dataexplorer/search/nodesReview Checklist