Fix loading of analyses in gear suggest endpoint #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small change, will merge when CI is green |
|
@nagem Can we get a test that will catch this type of regression in the future? |
|
@ryansanford Writing a test would have taken 10x the time it took to fix it, so I wanted to get that part of the change merged first. I'll add a test in a followup PR. |
|
@ryansanford can you ping me and @tcbtcb when there is a release with this patch? Columbia and VA Palo Alto need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899
Analyses used to be attached to containers, now they need to be loaded separately.
Review Checklist