Skip to content

Minor adjustments to access log csv #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2017
Merged

Minor adjustments to access log csv #913

merged 4 commits into from
Aug 28, 2017

Conversation

nagem
Copy link
Contributor

@nagem nagem commented Aug 27, 2017

Changed:

  • Formatted timestamp field as ISO in UTC for access log csv
  • Created build_csv as an instance method to base Report class (to support exporting other reports as csv in the future)
  • Modified the order of the columns in access log csv
  • Fixed bug where the logging functionality was still looking for the group label under name

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@nagem nagem requested a review from hkethi002 August 27, 2017 23:41
@nagem nagem force-pushed the timestamp-format-csv branch from f08e752 to 330ca9c Compare August 28, 2017 03:28
@nagem nagem merged commit b8929f5 into master Aug 28, 2017
@nagem nagem deleted the timestamp-format-csv branch August 28, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkethi002 hkethi002 Awaiting requested review from hkethi002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nagem