Add CAS Auth Type #927
Add CAS Auth Type #927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
- Coverage 90.2% 90.13% -0.07%
==========================================
Files 48 48
Lines 6419 6458 +39
==========================================
+ Hits 5790 5821 +31
- Misses 629 637 +8
Continue to review full report at Codecov.
|
api/auth/authproviders.py
Outdated
| } | ||
|
|
||
| def validate_user(self, token): | ||
| config.log.warning('the config is {}\n\n'.format(self.config)) |
There was a problem hiding this comment.
Remove when you're ready to merge, or add more text to specify
| tree = ElementTree.fromstring(response) | ||
|
|
||
| # check to see if xml response labeled request as success | ||
| if tree[0].tag.endswith('authenticationSuccess'): |
There was a problem hiding this comment.
Add a link to where this logic is sourced from - just a github link to cas library source is fine.
api/auth/authproviders.py
Outdated
| raise APIAuthProviderException('Auth provider ticket verification unsuccessful.') | ||
|
|
||
| if not username: | ||
| raise APIAuthProviderException('Auth provider did not provide username') |
There was a problem hiding this comment.
Will these two exceptions be client-visible? Maybe remove "auth provider" from verbiage.
There was a problem hiding this comment.
We use that generically throughout AuthProviders but it is not shown to the client.
There was a problem hiding this comment.
Also this line has been removed.
nagem
force-pushed
the
cas-auth
branch
2 times, most recently
from
4fbc4df to
f0d7db9
Compare
|
@nagem Environmental var |
| self.abort(401, 'Inactivity timeout') | ||
|
|
||
| # set last_seen to now | ||
| config.db.authtokens.update_one({'_id': cached_token['_id']}, {'$set': {'last_seen': timestamp}}) |
There was a problem hiding this comment.
I would have assumed that the user's last_seen is always getting updated on every request. Are you sure it needs to be set here? If so, was it not being updated elsewhere?
Adds CAS Auth type support
Breaking Changes
None
Review Checklist