Skip to content

Conversation

nagem
Copy link
Contributor

@nagem nagem commented Sep 19, 2017

Fixes #931

Changes that require mimetype in jobs/add unearthed that the mimetype for a packfile upload was never persisted to the db.

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@nagem nagem requested review from ryansanford and kofalt September 19, 2017 17:29
@codecov-io
Copy link

codecov-io commented Sep 19, 2017

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          48       48           
  Lines        6413     6413           
=======================================
  Hits         5784     5784           
  Misses        629      629
Flag Coverage Δ
#python 90.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
api/placer.py 94.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4958909...fd7d378. Read the comment docs.

@ryansanford
Copy link
Contributor

Nice turnaround. I was able to confirm existing packfile uploads had the mimetype added, and new uploads now had it present.

I'm going to test against a larger database now before approving.

Copy link
Contributor

@kofalt kofalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, another cgi_field haunt eh 👻

Copy link
Contributor

@ryansanford ryansanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- sanitized production DBs updated within a couple seconds with the expected result.

@nagem nagem merged commit d014e7c into master Sep 19, 2017
@nagem nagem deleted the add-packfile-mimetype branch September 19, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants