Skip to content

Conversation

hkethi002
Copy link
Contributor

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem September 20, 2017 17:46
@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #933 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #933      +/-   ##
=========================================
+ Coverage   90.19%   90.2%   +<.01%     
=========================================
  Files          48      48              
  Lines        6418    6419       +1     
=========================================
+ Hits         5789    5790       +1     
  Misses        629     629
Flag Coverage Δ
#python 90.2% <100%> (ø) ⬆️
Impacted Files Coverage Δ
api/handlers/listhandler.py 90.67% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124ea0c...a2b419c. Read the comment docs.

@nagem
Copy link
Contributor

nagem commented Sep 29, 2017

It's too bad it'll take two calls, but changes look good. Maybe we can redesign how we propagate permissions at some point to make it a little smoother.

@hkethi002 hkethi002 merged commit 7526d48 into master Sep 29, 2017
@hkethi002 hkethi002 deleted the group-prop-put branch September 29, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants