Skip to content

Conversation

hkethi002
Copy link
Contributor

Fixes #916

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem September 20, 2017 19:29
@codecov-io
Copy link

Codecov Report

Merging #935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          48       48           
  Lines        6413     6413           
=======================================
  Hits         5784     5784           
  Misses        629      629
Flag Coverage Δ
#python 90.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d014e7c...f00ed12. Read the comment docs.

@nagem
Copy link
Contributor

nagem commented Sep 25, 2017

LGTM, nice reuse of the the 32nd upgrade script.

@hkethi002 hkethi002 merged commit ca6b0a8 into master Sep 25, 2017
@hkethi002 hkethi002 deleted the group-perm-site branch September 25, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants