Skip to content

Conversation

nagem
Copy link
Contributor

@nagem nagem commented Sep 26, 2017

Note: there is some logging logic in there that logs when file type/measurements are missing. I decided to leave that in for now.

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@nagem nagem requested review from gsfr and kofalt September 26, 2017 20:27
@codecov-io
Copy link

Codecov Report

Merging #942 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   90.19%   90.19%   +<.01%     
==========================================
  Files          48       48              
  Lines        6417     6418       +1     
==========================================
+ Hits         5788     5789       +1     
  Misses        629      629
Flag Coverage Δ
#python 90.19% <100%> (ø) ⬆️
Impacted Files Coverage Δ
api/jobs/rules.py 86.61% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6b0a8...4f55cf0. Read the comment docs.

@nagem nagem merged commit 124ea0c into master Sep 26, 2017
@nagem nagem deleted the file-type-fix branch September 26, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants