Skip to content

Conversation

hkethi002
Copy link
Contributor

@hkethi002 hkethi002 commented Nov 10, 2017

Fixes #944

Changes From #877

  • Project phi field (required field when creating project)
    • if project.phi == true, projects can have custom phi list
    • if phi is disabled for project, it is the same as if everyone has phi-access and modifying custom-phi lists is not allowed
  • New collection of custom phi list for projects and site-level default
    • Project admins can set project level lists, site admins can set site-level lists
    • New ProjectSettings handler for custom-phi and project templates logic, rules are also in the same file
    • can only set phi fields that are PHI_CANDIDATES (this is a hardcoded list)
    • User can selectively choose subfields of the candidates
  • New decorator to check phi-access for POST and PUT methods
  • GET
    • get_all uses site level default phi fields
  • If tags/notes are marked as PHI,
    • should a non-PHI user be able to add? - Yes
    • view? No
    • modify? - Yes for own notes, tags cannot be modified
    • delete? - Yes for own notes, no(?) for tags, but we'll allow for now.
  • New AccessType modify-phi-list

ToDo

  • Project phi field that enables phi functionality
  • Subfields of PHI_CANDIDATES need to be permitted as phi fields
  • Log changes made to custom phi lists
  • Add more tests
  • Redo the phi logic for list handlers (Notes and Tags)

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@hkethi002 hkethi002 requested a review from nagem November 10, 2017 17:18
@hkethi002 hkethi002 changed the title Custom phi 2 Custom PHI lists at project level Nov 10, 2017
@hkethi002 hkethi002 changed the title Custom PHI lists at project level Custom PHI lists at site/project level Nov 10, 2017
@codecov-io
Copy link

codecov-io commented Nov 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (PHI-perm-three@406ac2d). Click here to learn what that means.
The diff coverage is 92.33%.

@@                Coverage Diff                @@
##             PHI-perm-three     #991   +/-   ##
=================================================
  Coverage                  ?   91.17%           
=================================================
  Files                     ?       51           
  Lines                     ?     7049           
  Branches                  ?        0           
=================================================
  Hits                      ?     6427           
  Misses                    ?      622           
  Partials                  ?        0

@hkethi002 hkethi002 force-pushed the PHI-perm-three branch 2 times, most recently from f999ae5 to 2e81556 Compare November 13, 2017 15:09
@hkethi002 hkethi002 force-pushed the custom-phi-2 branch 2 times, most recently from 03e23bb to 6ca515f Compare November 13, 2017 18:59
@hkethi002 hkethi002 force-pushed the custom-phi-2 branch 2 times, most recently from 59e58b4 to 5816f4b Compare November 15, 2017 16:15
@hkethi002 hkethi002 force-pushed the PHI-perm-three branch 2 times, most recently from af4f116 to 406ac2d Compare December 21, 2017 17:00
@nagem
Copy link
Contributor

nagem commented Feb 19, 2018

Closing PR for now as requirements for this enhancement are reworked within the team.

@nagem nagem closed this Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants