Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chuck #62

Merged
merged 3 commits into from Jan 23, 2019
Merged

add chuck #62

merged 3 commits into from Jan 23, 2019

Conversation

bgreenwell
Copy link
Contributor

No description provided.

@sckott
Copy link
Owner

sckott commented Sep 18, 2018

thanks @bgreenwell

Can you give some context for this. What is chuck?

I see

 ------
    \
     \
      @@@@@@@
      @@@@@@@@
     @@@@@@@@@@
     @@@@@@@@@@@@@@
  @@@@  @@   @@@@@@
               @@
       @@@   @@@
      @   @   @
       @@    @@@
  @@@@ @@@@@@@@@@@ [nosig]

Is this as intended? I don't quite see a shape there.

@bgreenwell
Copy link
Contributor Author

Ahh, my apologies, that is an asci image of Chuck Norris! In particular, it is an ascii image of
chuck-norris

Im am able to make a more refined version as well, but I settled on this size as a compromise.

@sckott
Copy link
Owner

sckott commented Sep 20, 2018

thanks for the clarification. So you made the ascii ? just checking.

Do you think you could alter it at all? I don't really see the resemblance. I mean I can't really tell that it's supposed to look like Chuck Norris.

What do you think @aedobbyn ?

@aedobbyn
Copy link
Contributor

I agree with @sckott. Size isn't a big issue, at least not vertical size (see e.g. yoda and endless horse. I think bigger with more detail is the right tradeoff to make. Also, if you made it @bgreenwell feel free to add your sig, if you want :)

@bgreenwell
Copy link
Contributor Author

I generated the ascii, but the image is from google, and used as part of this package's logo.

I can certainly increase the size, but what do you think would be a reasonable max width, 80 characters (that's just slightly larger than what = "bat2"? Let me know and I will submit a new pull request.

@aedobbyn
Copy link
Contributor

80 seems reasonable to me, I probably wouldn't go any wider

@sckott
Copy link
Owner

sckott commented Sep 21, 2018

@bgreenwell you don't have to create a new PR, you can just add commits to this PR (i.e., bgreenwell:master branch)

@bgreenwell
Copy link
Contributor Author

Will do!

@bgreenwell
Copy link
Contributor Author

Referencing this pull request.

@sckott
Copy link
Owner

sckott commented Jan 23, 2019

LGTM, any thoughts @aedobbyn ?

@aedobbyn
Copy link
Contributor

Looks great, nice work @bgreenwell!

@sckott sckott added this to the v0.8 milestone Jan 23, 2019
@sckott
Copy link
Owner

sckott commented Jan 23, 2019

thanks @bgreenwell

@sckott sckott merged commit 7080f21 into sckott:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants