-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add chuck #62
add chuck #62
Conversation
thanks @bgreenwell Can you give some context for this. What is chuck? I see
Is this as intended? I don't quite see a shape there. |
thanks for the clarification. So you made the ascii ? just checking. Do you think you could alter it at all? I don't really see the resemblance. I mean I can't really tell that it's supposed to look like Chuck Norris. What do you think @aedobbyn ? |
I agree with @sckott. Size isn't a big issue, at least not vertical size (see e.g. yoda and endless horse. I think bigger with more detail is the right tradeoff to make. Also, if you made it @bgreenwell feel free to add your sig, if you want :) |
I generated the ascii, but the image is from google, and used as part of this package's logo. I can certainly increase the size, but what do you think would be a reasonable max width, 80 characters (that's just slightly larger than |
80 seems reasonable to me, I probably wouldn't go any wider |
@bgreenwell you don't have to create a new PR, you can just add commits to this PR (i.e., |
Will do! |
Referencing this pull request. |
LGTM, any thoughts @aedobbyn ? |
Looks great, nice work @bgreenwell! |
thanks @bgreenwell |
No description provided.