chore: Add the faas-js-runtime to the testing suite. #377

lholmquist · 2023-01-30T19:14:52Z

The faas-js-runtime is the framework which runs and invokes node.js serverless functions for Openshift Serverless.

lholmquist · 2023-01-30T19:15:18Z

[test]

lholmquist · 2023-01-31T17:10:25Z

[test]

lholmquist · 2023-02-02T13:48:17Z

[test]

lholmquist · 2023-02-02T15:14:18Z

@zmiklank not sure what is going on with the tests. doesn't look like it has anything to do with what I've added

pkubatrh · 2023-02-02T16:41:31Z

We are seeing issues with RHEL-based CI due to some of the infrastructure used for the tests getting refreshed over the coming week or two. I expect we will have to wait until that is done before the tests have a chance to get green.

What I find more troubling is that I do not see client test case results in the test runs that did pass. The only mention of them is this

Running tests for image quay.io/fedora/nodejs-18:18
-----------------------------------------------
Running test test_client_express (starting at 2023-02-02 14:03:19+00:00) ... 
-----------------------------------------------
Running express client test
Running express test suite
Please specify a valid test application

Rerunning the tests locally with more versbosity:

 echo 'Running test test_client_express (starting at 2023-02-02 17:22:17+01:00) ... '
Running test test_client_express (starting at 2023-02-02 17:22:17+01:00) ... 
+ echo -----------------------------------------------
-----------------------------------------------
+ test_client_express
+ echo 'Running express client test'
Running express client test
+ test_running_client_js express
+ echo 'Running express test suite'
Running express test suite
+ prepare express
+ image_exists quay.io/fedora/nodejs-18:18
+ docker inspect quay.io/fedora/nodejs-18:18
+ case "$1" in
+ [[  test_client_express
test_client_pino
test_client_prom
test_client_opossum
test_client_kube
test_client_faas
  =~ test_client_express  ]]
+ echo 'Please specify a valid test application'
Please specify a valid test application
+ exit 1
+ ct_cleanup
+ ct_show_resources
+ echo

This seems like a bug and the client cases are ignored completely. Also an error like this should have at least failed the whole test suite.

pkubatrh · 2023-02-03T10:54:42Z

Immediate issues in the client test case runner will be fixed in #378

mhdawson

LGTM

pkubatrh · 2023-02-23T13:48:30Z

Now that #378 is merged, please rebase and lets try this once more.

The faas-js-runtime is the framework which runs and invokes node.js serverless functions for Openshift Serverless.

lholmquist · 2023-02-23T15:05:32Z

rebased

lholmquist · 2023-02-23T15:05:40Z

[test]

lholmquist · 2023-02-23T16:20:10Z

Looks like these failures are unrelated to the client tests

pkubatrh · 2023-02-27T11:48:46Z

The tests fail with test/test-lib.sh: line 1300: test_client_faas: command not found

Looking at the changes it seems like the test case wrapper function (something like https://github.com/sclorg/s2i-nodejs-container/blob/master/test/test-lib-nodejs.sh#L392) is missing.

lholmquist · 2023-02-27T14:28:15Z

Ah yes, that part wasn't there when we added the previous clients. Added the function

lholmquist · 2023-02-27T14:28:22Z

[test]

lholmquist · 2023-02-27T16:01:07Z

Looks like the failures are unrelated to this PR.

pkubatrh · 2023-02-28T14:41:45Z

Looks like more pino failures :/ Let me rerun failed jobs to see if they managed to change in the meantime.

lholmquist · 2023-02-28T19:18:38Z

Since the failure doesn't have to do with this PR, could we get this merged and I will create another issue for our team to look at regarding the pinot tests?

pkubatrh · 2023-03-02T11:06:10Z

RHEL8 tests for Node 18 failing on faas-js:

  ---
    operator: error
    at: Test.<anonymous> (/opt/app-root/src/test/test.js:459:13)
    stack: |-
      Error: expected 200 "OK", got 503 "Service Unavailable"
          at /opt/app-root/src/test/test.js:456:10
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      ----
          at Test._assertStatus (/opt/app-root/src/node_modules/supertest/lib/test.js:252:14)
          at /opt/app-root/src/node_modules/supertest/lib/test.js:308:13
          at Test._assertFunction (/opt/app-root/src/node_modules/supertest/lib/test.js:285:13)
          at Test.assert (/opt/app-root/src/node_modules/supertest/lib/test.js:164:23)
          at localAssert (/opt/app-root/src/node_modules/supertest/lib/test.js:120:14)
          at /opt/app-root/src/node_modules/supertest/lib/test.js:125:7
          at Request.callback (/opt/app-root/src/node_modules/superagent/lib/node/index.js:866:3)
          at /opt/app-root/src/node_modules/superagent/lib/node/index.js:1057:18
          at IncomingMessage.<anonymous> (/opt/app-root/src/node_modules/superagent/lib/node/parsers/json.js:21:7)
          at IncomingMessage.emit (node:events:525:35)
  ...
�[31mnot ok 96 should be strictly equal�[0m
  ---
    operator: equal
    expected: |-
      'OK'
    actual: |-
      '{"statusCode":503,"error":"Service Unavailable","message":"res.setHeader is not a function"}'
    at: Test.<anonymous> (/opt/app-root/src/test/test.js:460:13)
    stack: |-
      Error: should be strictly equal
          at Test.assert [as _assert] (/opt/app-root/src/node_modules/tape/lib/test.js:312:48)
          at Test.bound [as _assert] (/opt/app-root/src/node_modules/tape/lib/test.js:95:17)
          at Test.strictEqual (/opt/app-root/src/node_modules/tape/lib/test.js:476:7)
          at Test.bound [as equal] (/opt/app-root/src/node_modules/tape/lib/test.js:95:17)
          at Test.<anonymous> (/opt/app-root/src/test/test.js:460:13)
          at Test.assert (/opt/app-root/src/node_modules/supertest/lib/test.js:172:8)
          at localAssert (/opt/app-root/src/node_modules/supertest/lib/test.js:120:14)
          at /opt/app-root/src/node_modules/supertest/lib/test.js:125:7
          at Request.callback (/opt/app-root/src/node_modules/superagent/lib/node/index.js:866:3)
          at /opt/app-root/src/node_modules/superagent/lib/node/index.js:1057:18
  ...

Node 16 on RHEL8 failed due to what looks like infra issues, will try rerunning once more.
The rest is pino failures

lholmquist · 2023-03-02T16:37:53Z

@pkubatrh is there a way to test that RHEL8 node 18 image locally?

i tried to do this podman run -it ubi8/nodejs-18:1 /bin/bash but i got an authentication error and i don't know where i'm suppose to authenticate to 🤷

lholmquist · 2023-03-02T16:42:58Z

Also wanted to mention that i created an issue for the pino failures: #381

lholmquist · 2023-03-02T16:43:10Z

[test]

pkubatrh · 2023-03-03T12:07:55Z

@lholmquist You likely defaulted to the authenticated red hat registry (registy.redhat.io), try podman run -it registry.access.redhat.com/ubi8/nodejs-18:1 /bin/bash instead

lholmquist · 2023-03-03T12:44:43Z

You likely defaulted to the authenticated red hat registry (registy.redhat.io),

@pkubatrh most likely

I did re-run the test suite and it looks like that issue where the faas-js client failed resolved itself. Still seeing those pino failures, but i created a new issue for that #381

pkubatrh · 2023-03-03T13:08:17Z

Rerunning RHEL8 tests to see if faas-js manages to pass.

lholmquist · 2023-03-03T14:29:21Z

🎉

pkubatrh mentioned this pull request Feb 3, 2023

tests: fail fast when prepare step fails #379

Closed

mhdawson approved these changes Feb 7, 2023

View reviewed changes

chore: Add the faas-js-runtime to the testing suite.

1834101

The faas-js-runtime is the framework which runs and invokes node.js serverless functions for Openshift Serverless.

lholmquist force-pushed the add-faas-js-runtime-to-testing branch from 2e10ab4 to 1834101 Compare February 23, 2023 15:04

squash: don't forget the test client functions

e50d304

pkubatrh self-requested a review March 3, 2023 14:28

pkubatrh approved these changes Mar 3, 2023

View reviewed changes

pkubatrh merged commit 3b9e360 into sclorg:master Mar 3, 2023

lholmquist mentioned this pull request Mar 7, 2023

chore: Add the fastify to the testing suite. #382

Closed

lholmquist deleted the add-faas-js-runtime-to-testing branch May 2, 2023 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add the faas-js-runtime to the testing suite. #377

chore: Add the faas-js-runtime to the testing suite. #377

lholmquist commented Jan 30, 2023

lholmquist commented Jan 30, 2023

lholmquist commented Jan 31, 2023

lholmquist commented Feb 2, 2023

lholmquist commented Feb 2, 2023

pkubatrh commented Feb 2, 2023

pkubatrh commented Feb 3, 2023

mhdawson left a comment

pkubatrh commented Feb 23, 2023

lholmquist commented Feb 23, 2023

lholmquist commented Feb 23, 2023

lholmquist commented Feb 23, 2023

pkubatrh commented Feb 27, 2023

lholmquist commented Feb 27, 2023

lholmquist commented Feb 27, 2023

lholmquist commented Feb 27, 2023

pkubatrh commented Feb 28, 2023

lholmquist commented Feb 28, 2023

pkubatrh commented Mar 2, 2023

lholmquist commented Mar 2, 2023

lholmquist commented Mar 2, 2023

lholmquist commented Mar 2, 2023

pkubatrh commented Mar 3, 2023

lholmquist commented Mar 3, 2023

pkubatrh commented Mar 3, 2023

lholmquist commented Mar 3, 2023

chore: Add the faas-js-runtime to the testing suite. #377

chore: Add the faas-js-runtime to the testing suite. #377

Conversation

lholmquist commented Jan 30, 2023

lholmquist commented Jan 30, 2023

lholmquist commented Jan 31, 2023

lholmquist commented Feb 2, 2023

lholmquist commented Feb 2, 2023

pkubatrh commented Feb 2, 2023

pkubatrh commented Feb 3, 2023

mhdawson left a comment

Choose a reason for hiding this comment

pkubatrh commented Feb 23, 2023

lholmquist commented Feb 23, 2023

lholmquist commented Feb 23, 2023

lholmquist commented Feb 23, 2023

pkubatrh commented Feb 27, 2023

lholmquist commented Feb 27, 2023

lholmquist commented Feb 27, 2023

lholmquist commented Feb 27, 2023

pkubatrh commented Feb 28, 2023

lholmquist commented Feb 28, 2023

pkubatrh commented Mar 2, 2023

lholmquist commented Mar 2, 2023

lholmquist commented Mar 2, 2023

lholmquist commented Mar 2, 2023

pkubatrh commented Mar 3, 2023

lholmquist commented Mar 3, 2023

pkubatrh commented Mar 3, 2023

lholmquist commented Mar 3, 2023