fix(rsync): Try getting rsync arguments BSD style #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedayak
force-pushed
the
rsync-bsd-style
branch
from
f8a6c3d to
0907add
Compare
akinomyoga
reviewed
Oct 10, 2025
scop
reviewed
Oct 12, 2025
test/t/test_rsync.py
Outdated
| def test_3(self, completion): | ||
| assert completion == "rsh ssh".split() | ||
|
|
||
| @pytest.mark.complete("rsync --", require_cmd=True) |
There was a problem hiding this comment.
I wonder if require_longopt would be in order here, instead of require_cmd?
There was a problem hiding this comment.
Yeah it makes sense, I don't think I knew we had that option
There is a BSD licensed version of rsync at https://github.com/kristapsdz/openrsync, and its what comes with macOS
yedayak
force-pushed
the
rsync-bsd-style
branch
from
0907add to
078ab1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a BSD licensed version of rsync at https://github.com/kristapsdz/openrsync, and its what comes with macOS
Cherry picked from #1339