-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coding style #106
Improve coding style #106
Conversation
Yes, that is OK. In fact, you could also move the In principle, we could move all local imports and the scipy import outside. The local imports are available anyway, and scipy is a obligatory dependency of scot. Only |
@mbillingr I've changed the input argument order in some functions. Could you please check if this is OK, or are we unnecessarily breaking the API? I thought the new order makes more sense. |
I think I'm going to revert the changed argument order. The statistics example produces different results. |
The problem with changing the argument order is that you will never know for sure if you found all the places where the function is used. |
Agreed. That's why I reverted it. |
@cle1109 can you rebase this branch to the current master? |
51b34ad
to
6724974
Compare
@mbillingr could you please check if the changes are OK? If yes, please merge it - I want to avoid blowing up this PR more, because this means a lot of manual merging when rebasing. We can continue to improve the code style in another PR. |
Fixes #79. @mbillingr can you confirm if it is OK to move the
cat_trials
import outside of the function?