-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anaconda 2.5 #115
Anaconda 2.5 #115
Conversation
Damn, I think I branched from the wrong branch :) |
Good that it's not only me who messes up the repo :-P. |
Damn again! :) |
Yay! With a bit of practice it becomes possible to fix all these GIT mess-ups. |
Sure - rewriting history rocks! Back on topic, so this means we're using MKL only with Python 3? Shouldn't we also use MKL with Python 2? This way, we would test the two default Anaconda envs. In addition, we have an "oldest supported" env, which could be the non-MKL one with Python 2 and old packages. |
So isn't Travis going to run the tests? |
Checks passed. They ran in the background. Logs look good too - I've enabled MKL in the Python 3 test and disabled it in the Python 2 and the compaitibility tests. This is what we get: Default numpy build with MKL
Special nomkl numpy build that's using openblas instead
|
OK! Do you want to use the default current Python 2.7 version (i.e. with MKL)? |
Hmm... I don't know. MKL and BLAS are supposed to be equivalent and it's not our task to verify that. So, do we need to test both, with and without MKL? It may be best to stick to the default which everybody may be using in the future (and which hopefully also makes our tests faster). This would mean using MKL in the tests, but we could disable it in the compatibility check. What do you think? |
Exactly, we shouldn't even have to deal with the question MKL or non-MKL. Therefore, let's just take the standard Anaconda installs - which means, starting with 2.5, MKL-enabled 3.5 and 2.7. We can even use the default MKL 2.7 with the oldest supported packages. What do you mean with disabling MKL in the compatibility check? |
I meant not to use MKL with the old packages. |
Ah - yes, this sounds good. Could you update the envs accordingly? Plus, the three envs should set the same variables - currently, the Python 3 env doesn't set the Finally, we should update the Python 3 env to Python 3.5. |
Anything else? |
Since you're asking, can you increase the verbosity of the tests? Currently, there's only one line of dots... |
Since you mention it, I've been planning to do that for a long time :) |
:-) |
Btw, feel free to merge. |
Anaconda 2.5 comes by default with MKL. It can be disabled by installing
nomkl
.Details here.