Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaconda 2.5 #115

Merged
merged 5 commits into from
Feb 9, 2016
Merged

Anaconda 2.5 #115

merged 5 commits into from
Feb 9, 2016

Conversation

mbillingr
Copy link
Member

Anaconda 2.5 comes by default with MKL. It can be disabled by installing nomkl.
Details here.

@mbillingr
Copy link
Member Author

Damn, I think I branched from the wrong branch :)

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

Good that it's not only me who messes up the repo :-P.

@mbillingr
Copy link
Member Author

Damn again! :)

@mbillingr
Copy link
Member Author

Yay! With a bit of practice it becomes possible to fix all these GIT mess-ups.

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

Sure - rewriting history rocks!

Back on topic, so this means we're using MKL only with Python 3? Shouldn't we also use MKL with Python 2? This way, we would test the two default Anaconda envs. In addition, we have an "oldest supported" env, which could be the non-MKL one with Python 2 and old packages.

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

So isn't Travis going to run the tests?

@mbillingr
Copy link
Member Author

Checks passed. They ran in the background.

Logs look good too - I've enabled MKL in the Python 3 test and disabled it in the Python 2 and the compaitibility tests.

This is what we get:

Default numpy build with MKL

    package                    |            build
    ---------------------------|-----------------
    libgfortran-1.0            |                0         170 KB
    mkl-11.3.1                 |                0       121.2 MB
    python-3.4.4               |                0        15.3 MB
    numpy-1.10.4               |           py34_0         5.9 MB
    ...

Special nomkl numpy build that's using openblas instead

    package                    |            build
    ---------------------------|-----------------
    libgfortran-1.0            |                0         170 KB
    nomkl-1.0                  |                0          402 B
    openblas-0.2.14            |                3         3.5 MB
    python-2.7.11              |                0        12.0 MB
    numpy-1.10.4               |     py27_nomkl_0         6.0 MB
    ...

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

OK! Do you want to use the default current Python 2.7 version (i.e. with MKL)?

@mbillingr
Copy link
Member Author

Hmm... I don't know.

MKL and BLAS are supposed to be equivalent and it's not our task to verify that. So, do we need to test both, with and without MKL?
Do we want the Python 2 and Python 3 tests to be identical?
Do we want to avoid too many test runs?

It may be best to stick to the default which everybody may be using in the future (and which hopefully also makes our tests faster). This would mean using MKL in the tests, but we could disable it in the compatibility check. What do you think?

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

Exactly, we shouldn't even have to deal with the question MKL or non-MKL. Therefore, let's just take the standard Anaconda installs - which means, starting with 2.5, MKL-enabled 3.5 and 2.7. We can even use the default MKL 2.7 with the oldest supported packages.

What do you mean with disabling MKL in the compatibility check?

@mbillingr
Copy link
Member Author

What do you mean with disabling MKL in the compatibility check?

I meant not to use MKL with the old packages.

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

Ah - yes, this sounds good. Could you update the envs accordingly?

Plus, the three envs should set the same variables - currently, the Python 3 env doesn't set the RUN_EXAMPLES variable, and so on.

Finally, we should update the Python 3 env to Python 3.5.

@mbillingr
Copy link
Member Author

Anything else?

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

Since you're asking, can you increase the verbosity of the tests? Currently, there's only one line of dots...

@mbillingr
Copy link
Member Author

Since you mention it, I've been planning to do that for a long time :)

@cbrnr
Copy link
Contributor

cbrnr commented Feb 9, 2016

:-)

@mbillingr
Copy link
Member Author

Btw, feel free to merge.

cbrnr added a commit that referenced this pull request Feb 9, 2016
@cbrnr cbrnr merged commit 368acb4 into scot-dev:master Feb 9, 2016
@mbillingr mbillingr deleted the anaconda25 branch February 9, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants