Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codecov support #155

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Added codecov support #155

merged 2 commits into from
Mar 15, 2016

Conversation

mbillingr
Copy link
Member

Fixes #154

Let's see if it works that easily :)

@mbillingr mbillingr self-assigned this Mar 15, 2016
@codecov-io
Copy link

Current coverage is 93.17%

Branch #155 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

@cbrnr
Copy link
Contributor

cbrnr commented Mar 15, 2016

Nice! +1 for merging!

@mbillingr
Copy link
Member Author

Codecov reports a slightly lower coverage than Coveralls. I think that is because coveralls has something like "partial hits" that are not counted. I don't know yet what they signify :)

@cbrnr
Copy link
Contributor

cbrnr commented Mar 15, 2016

Since all coverage services are using coverage, I'm pretty sure they can be set to yield exactly identical results. However, I'm happy with the Codecov number - everything >90% is great!

@cbrnr
Copy link
Contributor

cbrnr commented Mar 15, 2016

Why didn't @codecov-io comment after the last commit?

@mbillingr
Copy link
Member Author

Maybe it only updates the first comment to avoid clutter?

mbillingr added a commit that referenced this pull request Mar 15, 2016
@mbillingr mbillingr merged commit bc663ef into scot-dev:master Mar 15, 2016
@cbrnr
Copy link
Contributor

cbrnr commented Mar 15, 2016

It didn't update the first comment, or did it?

@mbillingr
Copy link
Member Author

Coverage did not change in this PR. It updated the comment in #156, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants