Fixes for linechart directive and minor documentation fix #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2015 13:13
|
Thanks! I am glad someone else is finding a use for it :) |
scottux
pushed a commit
that referenced
this pull request
May 4, 2015
Linechart suffered from bad copy pasta. Thanks @jclemans Updated the concatenated and minified files. Bumped version.
|
I have included the suggested change in the source files and rebuilt everything so that the documentation is now correct (the code was actually not updated correctly in the last release - it should have been values-x and values-y) so I made a new release with these changes added. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for creating this angular project. I'm using your code in a project and found a bug in the line chart directive. I went ahead and fixed it and wanted to share the fix back to you.
The issue was just that the linechart directive was generating a barchart due to a typo. I also made a change to the documentation for line charts so that the param names for valuesx and valuesy matches what graphael requires we use.
Hopefully this helps some other people that come across this repo!