ScoverageKeys.excludedPackages not working

[lmayumi]

Hi I have following settings override:
.settings(ScoverageKeys.excludedPackages := ";./twirl/.;.*template.scala;")

Basically I want to ignore all the files under package twirl and all the classes which ends with
template.scala. However I am getting errors below. It is obviously looking at the file which ends with template.scala. Why isn't excludePagages not working?

[scoverage]: Instrumentation completed [50838 statements]
[error]
[error] while compiling: /Users/ph/target/scala-2.10/twirl/main/views/html/testsAndPocs/dashboard.template.scala
[error] during phase: scoverage-instrumentation
[error] library version: version 2.10.4

[sksamuel]

Is twirl the package or just a directory?

On 23 September 2014 20:50, Mayumi Liyanage notifications@github.com
wrote:

Hi I have following settings override:
.settings(ScoverageKeys.excludedPackages := ";./twirl/.
;.*template.scala;")

Basically I want to ignore all the files under package twirl and all the
classes which ends with
template.scala. However I am getting errors below. It is obviously looking
at the file which ends with template.scala. Why isn't excludePagages not
working?

[scoverage]: Instrumentation completed [50838 statements]
[error]
[error] while compiling:
/Users/ph/target/scala-2.10/twirl/main/views/html/testsAndPocs/dashboard.template.scala
[error] during phase: scoverage-instrumentation
[error] library version: version 2.10.4

—
Reply to this email directly or view it on GitHub
#51.

[lmayumi]

When you compile the Play application code, all the files under app/views/[any_name].template.scala is compiled into the directory under target as /scala-2.10/twirl/main/views/html/[any_name].template.scala
Final structure looks like following:
target/
-------- scala-2.10/
------------------------ /scoverage-classes
------------------------ /scoverage-data
------------------------ /src_managed
------------------------ /twirl <--here

Note: I updated my excludePackage to include .view. or all non .scala files however I get the same result. Eventually I get GC limit exceed exception.
For more info: https://www.playframework.com/documentation/2.2.x/ScalaTemplates

Thanks

[sksamuel]

Ok, but excludePackages excludes by the package name of the scala class.
These classes - do they have twirl in the package name? It doesn't matter
what folder they aer in.

On 23 September 2014 21:14, Mayumi Liyanage notifications@github.com
wrote:

When you compile the Play application code, all the files under
app/views/[any_name].template.scala is compiled into the directory under
target as /scala-2.10/twirl/main/views/html/[any_name].template.scala
Final structure looks like following:
target/
scala-2.10/
/scoverage-classes
/scoverage-data
/src_managed
/twirl

Note: I updated my excludePackage to include .view. or all non .scala
files however I get the same result. Eventually I get GC limit exceed
exception.

Thanks

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[lmayumi]

Thank you very much for the response.
No, it is a namespace in play source. Can we exclude by the file name then? I tried .*template.scala to ignore all the files inside this twirl folder and it is still considered.

[sksamuel]

I will add a new key for exclusion by filename.

On 24 September 2014 03:17, Mayumi Liyanage notifications@github.com
wrote:

Thank you very much for the response.
No, it is a namespace in play source. Can we exclude by the file name
then? I tried .*template.scala to ignore all the files inside this twirl
folder and it is still considered.

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[lmayumi]

But in the readme, you mentioned that we could exclude the file names "The regular expressions are matched against the fully qualified class name, and must match the entire string to take effect." so I assumed we could exclude the files. Also when you make the changes could you put the link to the patch in this thread? Thanks!

[sksamuel]

Fqcn is not the filename. This is basic java stuff.
On 24 Sep 2014 15:50, "Mayumi Liyanage" notifications@github.com wrote:

But in the readme, you mentioned that we could exclude the file names "The
regular expressions are matched against the fully qualified class name, and
must match the entire string to take effect." so I assumed we could exclude
the files. Also when you make the changes could you put the link to the
patch in this thread? Thanks!

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[lmayumi]

What does Fqcn stand for?

[sksamuel]

Fully qualified class name.
On 24 Sep 2014 15:52, "Mayumi Liyanage" notifications@github.com wrote:

What does Fqcn stand for?

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[lmayumi]

Yes but all the files that I mentioned is still a .scala files..

[lmayumi]

The problem I am having with the .*template.scala file can be seen below. Can you decode what is the cause of the error?

[error] == Enclosing template or block ==
[error]
[error] Apply( // def invoked(id: Int,dataDir: String): Unit in object Invoker, tree.tpe=Unit
[error] "scoverage"."Invoker"."invoked" // def invoked(id: Int,dataDir: String): Unit in object Invoker, tree.tpe=(id: Int, dataDir: String)Unit
[error] // 2 arguments
[error] 50838
[error] "/Users/mayumi.liyanage/wm_browse/target/scala-2.10/scoverage-data"
[error] )
[error]
[error] == Expanded type of tree ==
[error]
[error] AliasTypeRef(
[error] pre = SingleType(
[error] pre = SingleType(
[error] pre = SingleType(
[error] pre = SingleType(
[error] pre = ThisType(package )
[error] package play
[error] )
[error] package twirl
[error] )
[error] package api
[error] )
[error] object HtmlFormat
[error] )
[error] Alias(type Appendable = T)
[error] normalize = TypeRef(
[error] TypeSymbol(
[error] class Html extends BufferedContent[play.twirl.api.Html]
[error] )
[error] )
[error] )
[error]

[massenz]

I am seeing a similar problem - the project is massenz/sentinel and is open here on github if you want to see the structure.

Essentially, there are a bunch of Play Framework (Scala) auto-generated classes, which end up being in various controllers and controllers.javascript packages, but whose names essentially all are with ReverseSomething.

I have added in build.sbt the following:

ScoverageKeys.excludedPackages := ".*Reverse.*"

but all these classes still appear in the coverage report (having, obviously, 0% coverage).
What are we missing here?

[sksamuel]

You could try to use excludedFiles.
On 17 Nov 2014 07:17, "Marco Massenzio" notifications@github.com wrote:

I am seeing a similar problem - the project is massenz/sentinel and is
open here on github if you want to see the structure.

Essentially, there are a bunch of Play Framework (Scala) auto-generated
classes, which end up being in various controllers and
controllers.javascript packages, but whose names essentially all are with
ReverseSomething.

I have added in build.sbt the following:

ScoverageKeys.excludedPackages := ".Reverse."

but all these classes still appear in the coverage report (having,
obviously, 0% coverage).
What are we missing here?

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

[massenz]

Thanks!
But I'm guessing this one is also for release 1.0? I'm getting a

/home/marco/workspaces/scala/sentinel/build.sbt:16: error: value excludedFiles is not a member of object scoverage.ScoverageSbtPlugin.ScoverageKeys
ScoverageKeys.excludedFiles := "target/.

However, it would really be great if you could look into excludedPackages - I like this one better for my use cases (also, the example in the README here seems to be covering exactly that case, so I'm guessing it's just something unclear in the doc... or just my being dense! :) )

thanks again for this great tool!

PS - at times, you find a great tool, and then you totally fall in love with one feature: the "fail on minimum coverage not reached" is quite likely to be the one for me ;-)

[sksamuel]

In 1.0 all the keys begin with coverageXXXX etc.
I'll add a test to check that excludePackages works on classnames too.

On 17 November 2014 08:04, Marco Massenzio notifications@github.com wrote:

Thanks!
But I'm guessing this one is also for release 1.0? I'm getting a

/home/marco/workspaces/scala/sentinel/build.sbt:16: error: value excludedFiles is not a member of object scoverage.ScoverageSbtPlugin.ScoverageKeys
ScoverageKeys.excludedFiles := "target/.

However, it would really be great if you could look into excludedPackages

• I like this one better for my use cases (also, the example in the README
  here seems to be covering exactly that case, so I'm guessing it's just
  something unclear in the doc... or just my being dense! :) )

thanks again for this great tool!

PS - at times, you find a great tool, and then you totally fall in love
with one feature: the "fail on minimum coverage not reached" is quite
likely to be the one for me ;-)

—
Reply to this email directly or view it on GitHub
#51 (comment)
.