Skip to content

fix: stick to scala-xml 1.x for 2.12 to align with the compiler. #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: stick to scala-xml 1.x for 2.12 to align with the compiler. #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ lazy val sharedSettings = List(
} else {
scalacOptions.value
}
}
},
libraryDependencies += "org.scalameta" %% "munit" % munitVersion % Test
)

lazy val root = Project("scalac-scoverage", file("."))
Expand All @@ -103,9 +104,6 @@ lazy val runtime = CrossProject(
name := "scalac-scoverage-runtime",
crossScalaVersions := Seq(defaultScala212, defaultScala213),
crossTarget := target.value / s"scala-${scalaVersion.value}",
libraryDependencies ++= Seq(
"org.scalameta" %% "munit" % munitVersion % Test
),
sharedSettings
)
.jvmSettings(
Expand All @@ -126,10 +124,7 @@ lazy val plugin =
crossTarget := target.value / s"scala-${scalaVersion.value}",
crossScalaVersions := bin212 ++ bin213,
crossVersion := CrossVersion.full,
libraryDependencies ++= Seq(
"org.scalameta" %% "munit" % munitVersion % Test,
"org.scala-lang" % "scala-compiler" % scalaVersion.value % Provided
),
libraryDependencies += "org.scala-lang" % "scala-compiler" % scalaVersion.value % Provided,
sharedSettings
)
.settings(
Expand All @@ -141,10 +136,16 @@ lazy val reporter =
project
.settings(
name := "scalac-scoverage-reporter",
libraryDependencies ++= Seq(
"org.scala-lang.modules" %% "scala-xml" % "2.0.0",
"org.scalameta" %% "munit" % munitVersion % Test
),
libraryDependencies += CrossVersion
.partialVersion(
scalaVersion.value
)
.map {
// Lock this for 2.12 to align with the compiler
// https://github.com/scala/scala/pull/9743
case ((2, 12)) => "org.scala-lang.modules" %% "scala-xml" % "1.0.6"
case _ => "org.scala-lang.modules" %% "scala-xml" % "2.0.1"
},
sharedSettings,
crossScalaVersions := Seq(defaultScala212, defaultScala213, defaultScala3)
)
Expand All @@ -154,9 +155,6 @@ lazy val domain =
project
.settings(
name := "scalac-scoverage-domain",
libraryDependencies ++= Seq(
"org.scalameta" %% "munit" % munitVersion % Test
),
sharedSettings,
crossScalaVersions := Seq(defaultScala212, defaultScala213, defaultScala3)
)
Expand All @@ -165,9 +163,6 @@ lazy val serializer =
project
.settings(
name := "scalac-scoverage-serializer",
libraryDependencies ++= Seq(
"org.scalameta" %% "munit" % munitVersion % Test
),
sharedSettings,
crossScalaVersions := Seq(defaultScala212, defaultScala213, defaultScala3)
)
Expand Down