-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing bug #179
base: master
Are you sure you want to change the base?
Fix typing bug #179
Conversation
src/arche/readers/items.py
Outdated
def categorize(df: pd.DataFrame) -> pd.DataFrame: | ||
"""Cast columns with repeating values to `category` type to save memory""" | ||
def categorize(df: pd.DataFrame) -> None: | ||
"""Cast columns with repeating values to `category` type inplace to save memory""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄
"""Cast columns with repeating values to `category` type inplace to save memory""" | |
"""Cast columns with repeating values to `category` type in place to save memory""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inplace is a valid word :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find it in any online English dictionary :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google translate failed me, it didn't suggest the correction :)
Docs tests are failing, probably something wrong with a test org on scrapinghub or with the data in this org. |
No description provided.