Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing bug #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typing bug #179

wants to merge 3 commits into from

Conversation

manycoding
Copy link
Contributor

No description provided.

Gallaecio
Gallaecio reviewed Dec 6, 2019
View reviewed changes
src/arche/readers/items.py Outdated
def categorize(df: pd.DataFrame) -> pd.DataFrame:
"""Cast columns with repeating values to `category` type to save memory"""
def categorize(df: pd.DataFrame) -> None:
"""Cast columns with repeating values to `category` type inplace to save memory"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄

Suggested change
"""Cast columns with repeating values to `category` type inplace to save memory"""
"""Cast columns with repeating values to `category` type in place to save memory"""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inplace is a valid word :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find it in any online English dictionary :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google translate failed me, it didn't suggest the correction :)

@manycoding
Copy link
Contributor Author

Docs tests are failing, probably something wrong with a test org on scrapinghub or with the data in this org.
I would check but I don't have any access anymore - I am not in Scrapinghub no more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manycoding @Gallaecio