Add auth to bitbucket requests, closes #58 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manycoding
requested review from
raphapassini,
ejulio,
victor-torres,
ivankivanov and
andyjmc
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 62.82% 63.13% +0.31%
==========================================
Files 25 25
Lines 1595 1603 +8
Branches 279 280 +1
==========================================
+ Hits 1002 1012 +10
+ Misses 569 567 -2
Partials 24 24
Continue to review full report at Codecov.
|
ivankivanov
approved these changes
Apr 16, 2019
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", |
There was a problem hiding this comment.
What do you think for adding an option for JSON or YAML config file.
There was a problem hiding this comment.
Nobody really requested this so far.
|
How would you test this code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs https://github.com/scrapinghub/arche/blob/245d9322ec30402db5a4b5371bb1b2c48b21acf7/docs/source/nbs/schema.ipynb