Save items data in df #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manycoding
requested review from
raphapassini,
ejulio,
victor-torres,
alexander-matsievsky and
ivankivanov
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
+ Coverage 65.47% 66.08% +0.6%
=========================================
Files 24 24
Lines 1596 1592 -4
Branches 278 274 -4
=========================================
+ Hits 1045 1052 +7
+ Misses 527 515 -12
- Partials 24 25 +1
Continue to review full report at Codecov.
|
manycoding
commented
Apr 29, 2019
| @@ -147,12 +148,6 @@ def data_quality_report(self, bucket: Optional[str] = None): | |||
| raise ValueError("Collections are not supported") | |||
| if not self.schema: | |||
| raise ValueError("Schema is empty") | |||
| if not self.report.results: | |||
There was a problem hiding this comment.
This should be dealt with in data_quality_report.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to prepare some work for #69
I am getting rid of dict, so it won't slow down implementing new df API. The changes are big (I also included a tad which is not related to pr), but I am going to comment some code here to help you understand.
Feel free to skip a review if you find it too complex :)
itertuples()to iterate.json_val_df_dict.ipynb.zip
You can launch them from here https://mybinder.org/v2/gh/scrapinghub/jupyterhub-stacks/master?filepath=arche-notebook
P.S. Data can be validated at once without any iteractions, but
jsonschemais awfully slow for this and it will require creating different schemas. Which, in turn, make them incompatible with current spidermon validation. Thus, at this point I don't see this bottleneck as critical to address. It shouldn't be slower than it is now anyway.