Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparing naive and aware #736

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Jul 1, 2020

This is a workaround to fix this: #679 and this: #491

However it's necessary to test it properly before merging it.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #736 into master will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   95.34%   95.31%   -0.04%     
==========================================
  Files         304      304              
  Lines        2622     2625       +3     
==========================================
+ Hits         2500     2502       +2     
- Misses        122      123       +1     
Impacted Files Coverage Δ
dateparser/parser.py 98.67% <85.71%> (-0.26%) ⬇️
dateparser/languages/dictionary.py 99.33% <0.00%> (ø)
dateparser/languages/validation.py 93.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a52ea...37f1af3. Read the comment docs.

@noviluni noviluni added this to the v1.0.0 milestone Sep 7, 2020
@noviluni noviluni modified the milestones: v1.0.0, 1.1.0 Sep 28, 2020
@noviluni
Copy link
Collaborator Author

related to this: #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant