Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse() - whitespace around sentence separators consumed after numbers #76

Closed
matth opened this issue Jul 5, 2022 · 1 comment
Closed

Comments

@matth
Copy link
Contributor

matth commented Jul 5, 2022

Small bug / issue. In normal operation the parse() function respects white space around sentence separators ...

>>> parse("foo , bar , baz .") 
'foo , bar , baz .'            

This is not the case when the white space follows a number ...

>>> parse("one , two , three .")
'1, 2, 3.'                     

Ideally the behaviour would be consistent and respect the original whitespace around any separators / words.

I have implemented a fix and pull request for this (issue #77).

matth pushed a commit to matth/number-parser that referenced this issue Jul 5, 2022
serhii73 pushed a commit that referenced this issue Nov 10, 2022
@serhii73
Copy link
Collaborator

Close because the PR is merged.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants