Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for py3.11. Remove py27, py35, py36, py37 #170

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

elacuesta
Copy link
Member

No description provided.

@Gallaecio
Copy link
Member

I’m taking this over, I would like it merged before #173.

@Gallaecio Gallaecio closed this Dec 19, 2023
@Gallaecio Gallaecio reopened this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06fe95c) 94.27% compared to head (7c1bbe0) 94.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   94.27%   94.07%   -0.21%     
==========================================
  Files          28       28              
  Lines        1957     1957              
==========================================
- Hits         1845     1841       -4     
- Misses        112      116       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio
Copy link
Member

Gallaecio commented Dec 19, 2023

I believe the remaining issue affecting Python 3.10+ is kevin1024/vcrpy#719. It is not entirely clear to me what’s the right fix to continue supporting Python 3.9 and earlier.

I have tried running pytest --update-cassettes locally as docs/quickstart.rst suggests, but it hangs on the very first test. I assume I am missing something, but I don’t know what. I imagine it requires to run something locally and change some parameters to point to it.

@elacuesta I think you might have reached this point in the past, I recall discussing something like this some time ago.

@Gallaecio
Copy link
Member

I cannot reproduce the pypy3 msgpack issue locally with the very same version of pypy 😕

@Gallaecio
Copy link
Member

I cannot reproduce the pypy3 msgpack issue locally with the very same version of pypy 😕

It seems it was a temporary CI issue, it got past that now.

@Gallaecio Gallaecio marked this pull request as ready for review December 19, 2023 14:16
@Gallaecio Gallaecio requested review from kmike and wRAR December 19, 2023 14:17
@branchvincent
Copy link

+1, looks ready to merge?

@Gallaecio Gallaecio merged commit d479ce5 into master Jan 18, 2024
13 of 14 checks passed
@elacuesta elacuesta deleted the python-versions branch January 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants